wu-sheng commented on a change in pull request #4894:
URL: https://github.com/apache/skywalking/pull/4894#discussion_r437981449



##########
File path: apm-sniffer/apm-sdk-plugin/pom.xml
##########
@@ -47,6 +47,7 @@
         <module>sharding-sphere-3.x-plugin</module>
         <module>sharding-sphere-4.x-plugin</module>
         <module>sharding-sphere-4.x-RC3-plugin</module>
+        <module>sharding-sphere-4.1.0-plugin</module>

Review comment:
       I still hope you could move all codes in one jar. You could see in the 
current codebase, there is no plugin for other libs like this :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to