HackerRookie commented on pull request #4942: URL: https://github.com/apache/skywalking/pull/4942#issuecomment-645836935
> Right now, we don't have the intent to separate the database. I can't tell whether we should or shouldn't, but either of them is not the reason, you break the cache. > > If you want to add the database entity as a part of topology and the analysis perspective, you should change the cache to include `host:port:db-name`, and also change the peer of the span, which could make the database metrics in the DB dashboard separated too.  In the case of multiple data sources, tags db.instance is currently wrong to take the value of the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
