[GitHub] [skywalking] codecov[bot] edited a comment on pull request #4967: Add Nacos back into SkyWalking as an option(nacos-1.3.0)

Sat, 27 Jun 2020 22:55:39 -0700 


codecov[bot] edited a comment on pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#issuecomment-648758537


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr&el=h1) 
Report
   > Merging 
[#4967](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/skywalking/commit/fb7912c6bdda06a233f4b3e18e71a87d3e4a8951&el=desc)
 will **increase** coverage by `0.07%`.
   > The diff coverage is `72.50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/skywalking/pull/4967/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4967      +/-   ##
   ============================================
   + Coverage     53.58%   53.66%   +0.07%     
   - Complexity     2941     2948       +7     
   ============================================
     Files          1392     1398       +6     
     Lines         30174    30294     +120     
     Branches       3365     3375      +10     
   ============================================
   + Hits          16170    16258      +88     
   - Misses        13219    13245      +26     
   - Partials        785      791       +6     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...onfiguration/nacos/NacosConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh)
 | `31.25% <31.25%> (ø)` | `3.00 <3.00> (?)` | |
   | 
[.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=)
 | `69.23% <69.23%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh)
 | `72.54% <72.54%> (ø)` | `0.00 <0.00> (?)` | |
   | 
[...cluster/plugin/nacos/ClusterModuleNacosConfig.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NDb25maWcuamF2YQ==)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[...uster/plugin/nacos/ClusterModuleNacosProvider.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9DbHVzdGVyTW9kdWxlTmFjb3NQcm92aWRlci5qYXZh)
 | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
   | 
[...erver/configuration/nacos/NacosServerSettings.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc1NlcnZlclNldHRpbmdzLmphdmE=)
 | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   | 
[.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=)
 | `65.42% <0.00%> (-3.74%)` | `13.00% <0.00%> (ø%)` | |
   | 
[...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==)
 | `83.87% <0.00%> (-3.23%)` | `8.00% <0.00%> (-1.00%)` | |
   | ... and [6 
more](https://codecov.io/gh/apache/skywalking/pull/4967/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr&el=footer). 
Last update 
[fb7912c...2d4222d](https://codecov.io/gh/apache/skywalking/pull/4967?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to