wu-sheng commented on a change in pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#discussion_r450267890
##########
File path:
oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/TraceServiceModuleConfig.java
##########
@@ -51,6 +51,9 @@
@Setter
@Getter
private UninstrumentedGatewaysConfig uninstrumentedGatewaysConfig;
+ @Setter
+ @Getter
+ private TraceSampleRateWatcher traceSampleRateWatcher;
Review comment:
Why config has reference to watcher? This is strange. Watcher should be
a part of `TraceSegmentSampler`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
