kezhenxu94 commented on a change in pull request #5030:
URL: https://github.com/apache/skywalking/pull/5030#discussion_r451256316



##########
File path: 
apm-sniffer/apm-sdk-plugin/graphql-plugin/graphql-9.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/graphql/v9/GraphqlInterceptor.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.plugin.graphql.v9;
+
+import graphql.execution.ExecutionPath;
+import graphql.execution.ExecutionStrategyParameters;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.tag.Tags;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+import org.apache.skywalking.apm.network.trace.component.ComponentsDefine;
+
+import java.lang.reflect.Method;
+import java.util.HashMap;
+import java.util.Map;
+
+public class GraphqlInterceptor implements InstanceMethodsAroundInterceptor {
+
+    @Override
+    public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class<?>[] argumentsTypes, MethodInterceptResult result) throws 
Throwable {
+        ExecutionStrategyParameters parameters = (ExecutionStrategyParameters) 
allArguments[1];
+        if (parameters == null || parameters.getParent().getPath() != 
ExecutionPath.rootPath()) {
+            return;
+        }
+        AbstractSpan span = 
ContextManager.createLocalSpan(parameters.getField().get(0).getName());
+        Tags.LOGIC_ENDPOINT.set(span, buildLogicEndpointSpan());
+        span.setComponent(ComponentsDefine.GRAPHQL);
+    }
+
+    @Override
+    public Object afterMethod(EnhancedInstance objInst, Method method, 
Object[] allArguments, Class<?>[] argumentsTypes, Object ret) throws Throwable {
+        ExecutionStrategyParameters parameters = (ExecutionStrategyParameters) 
allArguments[1];
+        if (parameters == null || parameters.getParent().getPath() != 
ExecutionPath.rootPath()) {
+            return ret;
+        }
+        ContextManager.stopSpan();
+        return ret;
+    }
+
+    @Override
+    public void handleMethodException(EnhancedInstance objInst, Method method, 
Object[] allArguments, Class<?>[] argumentsTypes, Throwable t) {
+        ExecutionStrategyParameters parameters = (ExecutionStrategyParameters) 
allArguments[1];
+        if (parameters == null || parameters.getParent().getPath() != 
ExecutionPath.rootPath()) {
+            return;
+        }
+        dealException(t);
+    }
+
+    private void dealException(Throwable throwable) {
+        AbstractSpan span = ContextManager.activeSpan();
+        span.errorOccurred();
+        span.log(throwable);
+    }
+
+    private String buildLogicEndpointSpan() {
+        Map<String, Object> logicEndpointSpan = new HashMap<>();
+        logicEndpointSpan.put("logic-span", true);
+        return logicEndpointSpan.toString();

Review comment:
       The value of `x-le` should be JSON format, this is obviously not the 
case by simply calling `toString` on a `Map`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to