innerpeacez commented on a change in pull request #4959:
URL: https://github.com/apache/skywalking/pull/4959#discussion_r452734438
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -264,6 +264,10 @@ configuration:
period: ${SW_CONFIG_CONSUL_PERIOD:1}
# Consul aclToken
aclToken: ${SW_CONFIG_CONSUL_ACL_TOKEN:""}
+ configmap:
+ period: ${SW_CONFIG_CONSUL_PERIOD:60}
Review comment:
typo: SW_CONFIG_CONSUL_PERIOD -> SW_CONFIG_CONFIGMAP_PERIOD
##########
File path: docs/en/setup/backend/dynamic-config.md
##########
@@ -103,3 +103,20 @@ configuration:
appId: ${SW_CONFIG_APOLLO_APP_ID:skywalking}
period: ${SW_CONFIG_APOLLO_PERIOD:5}
```
+
+## Dynamic Configuration Kuberbetes Configmap Implementation
+
+[configmap](https://kubernetes.io/docs/concepts/configuration/configmap/) is
also supported as DCC(Dynamic Configuration Center), to use it, just configured
as follows:
+
+```yaml
+configuration:
+ selector: ${SW_CONFIGURATION:configmap}
+ # [example]
(../../../../oap-server/server-configuration/configuration-configmap/src/test/resources/skywalking-dynamic-configmap.example.yaml)
+ configmap:
+ # Sync period in seconds. Defaults to 60 seconds.
+ period: ${SW_CONFIG_CONSUL_PERIOD:60}
Review comment:
typo: SW_CONFIG_CONSUL_PERIOD -> SW_CONFIG_CONFIGMAP_PERIOD
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
