Ax1an opened a new pull request #5097:
URL: https://github.com/apache/skywalking/pull/5097


   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   
   Fix apdex threshold config bug when dynamic configuration is enabled.
   This bug will result in a large number of warn logs, even if the 
service-apdex-threshold.yml file exist.
   
   - How to fix?
   
   Optimize processing logic.
   If there is a core.default.apdexThreshold in the dynamic configuration, use 
it.
   If there is no core.default.apdexThreshold in the dynamic configuration, the 
service-apdex-threshold.yml file is read. And it is read only once when the 
configuration is switched. For example, delete core.default.apdexThreshold in 
the dynamic configuration.
   Only print the warn log if the service-apdex-threshold.yml file does not 
exist.
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to