kezhenxu94 commented on a change in pull request #4967:
URL: https://github.com/apache/skywalking/pull/4967#discussion_r454304237
##########
File path: dist-material/release-docs/LICENSE
##########
@@ -311,6 +311,7 @@ The text of each license is the standard Apache 2.0 license.
consul-client 1.2.6: https://github.com/rickfast/consul-client, Apache 2.0
okhttp 3.9.0: https://github.com/square/okhttp, Apache 2.0
prometheus client_java 0.6.0: https://github.com/prometheus/client_java,
Apache 2.0
+ nacos 1.3.0: https://github.com/alibaba/nacos, Apache 2.0
Review comment:
```suggestion
nacos 1.3.1: https://github.com/alibaba/nacos, Apache 2.0
```
##########
File path: oap-server/pom.xml
##########
@@ -389,6 +389,16 @@
<artifactId>nacos-client</artifactId>
<version>${nacos.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.alibaba.nacos</groupId>
+ <artifactId>nacos-common</artifactId>
+ <version>${nacos.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.alibaba.nacos</groupId>
+ <artifactId>nacos-api</artifactId>
+ <version>${nacos.version}</version>
+ </dependency>
Review comment:
Why add these, they are unnecessary because they're transitive
dependencies of `nacos-client`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
