hanahmily opened a new pull request #5099:
URL: https://github.com/apache/skywalking/pull/5099
These changes intend to add health checks to elasticsearch storage plugin.
* Update elasticsearch client 6.x and 7.x to the latest version, which
tries to fix some underlying connection issues.
* Add HealthChecker to combinate between provider and storage service
client. The HealthChecker opts to "sync" strategy which means it doesn't set up
an async scheduler to check backend server periodically. That is because our
persistence timer will touch the storage server every 3 seconds(the default
value), so we can leverage it as a health checking trigger.
* Some users report issues like
https://github.com/elastic/elasticsearch/issues/39946, in this PR, I fix this
issue by recreating a new RestClient once catching the IllegalStateExecption
indicate the collection pool is closed under the hood.
I only update the elasticsearch 6 in the current commit. After getting
enough feedbacks to polish the implementation, I will update elasticsearch 7
accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
