kezhenxu94 commented on a change in pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#discussion_r454789951



##########
File path: docs/en/setup/backend/backend-receivers.md
##########
@@ -128,3 +129,20 @@ receiver-oc:
     gRPCHost: ${SW_OC_RECEIVER_GRPC_HOST:0.0.0.0}
     gRPCPort: ${SW_OC_RECEIVER_GRPC_PORT:55678}
 ```
+
+## Kafka receiver
+
+Kafka Receiver supports to receive `TraceSegment`, `JVMMetrics` and others of 
Agent reported as gRPC Receiver.
+Currently, it has to connect to the whole topic or single partition of topic 
when OAP is in cluster mode.
+And we have to configure **Zookeeper** as the OAP cluster management tool.

Review comment:
       I suggest not to use too many different terms when you're saying the 
same thing
   
   ```suggestion
   And we have to configure **Zookeeper** as the OAP cluster coordinator.
   ```

##########
File path: docs/en/setup/backend/backend-receivers.md
##########
@@ -128,3 +129,20 @@ receiver-oc:
     gRPCHost: ${SW_OC_RECEIVER_GRPC_HOST:0.0.0.0}
     gRPCPort: ${SW_OC_RECEIVER_GRPC_PORT:55678}
 ```
+
+## Kafka receiver
+
+Kafka Receiver supports to receive `TraceSegment`, `JVMMetrics` and others of 
Agent reported as gRPC Receiver.
+Currently, it has to connect to the whole topic or single partition of topic 
when OAP is in cluster mode.
+And we have to configure **Zookeeper** as the OAP cluster management tool.
+
+**Suggestion and recommend**, creating the Kafka topics by self before OAP 
Server starting. Although OAP server
+will create these if not exist.
+
+To active the `default` implementation:
+```yaml
+receiver-kafka:
+  selector: ${SW_RECEIVER_KAFKA:-}

Review comment:
       `-` won't active the implementation, instead, it disables the 
implementation

##########
File path: docs/en/setup/backend/backend-receivers.md
##########
@@ -128,3 +129,20 @@ receiver-oc:
     gRPCHost: ${SW_OC_RECEIVER_GRPC_HOST:0.0.0.0}
     gRPCPort: ${SW_OC_RECEIVER_GRPC_PORT:55678}
 ```
+
+## Kafka receiver

Review comment:
       The doc on agent side is missing?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to