zkscpqm commented on a change in pull request #38:
URL: https://github.com/apache/skywalking-python/pull/38#discussion_r456244258
##########
File path: requirements.txt
##########
@@ -0,0 +1,23 @@
+blindspin==2.0.1
+certifi==2020.6.20
+chardet==3.0.4
+colorama==0.4.3
+crayons==0.3.1
+deprecation==2.1.0
+docker==4.2.2
+grpcio==1.30.0
+grpcio-tools==1.30.0
+idna==2.10
+packaging==20.4
+protobuf==3.12.2
+PyMySQL==0.9.3
+pyparsing==2.4.7
+pypiwin32==223
+pywin32==228
+requests==2.24.0
+six==1.15.0
+testcontainers==3.0.3
+urllib3==1.25.9
+websocket-client==0.57.0
+Werkzeug==1.0.1
+wrapt==1.12.1
Review comment:
If we don't check it in, a new developer/user who is just downloading
the source will not have a way to set up their venv
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
