wu-sheng commented on a change in pull request #4972:
URL: https://github.com/apache/skywalking/pull/4972#discussion_r458084139



##########
File path: 
oap-server/server-bootstrap/src/main/resources/ui-initialized-templates.yml
##########
@@ -1067,4 +1067,124 @@ templates:
     # False means providing a basic template, user needs to add it manually.
     activated: true
     # True means wouldn't show up on the dashboard. Only keeps the definition 
in the storage.
+    disabled: false
+  - name: Spring-Sleuth
+    type: "DASHBOARD"
+    configuration: |-
+      [
+        {
+          "name":"Spring ",

Review comment:
       And notice, this change effects your screenshot, please consider the 
name. Because you have whitespace after `Spring`, I assume you are missing 
something.

##########
File path: 
oap-server/server-bootstrap/src/main/resources/ui-initialized-templates.yml
##########
@@ -1067,4 +1067,124 @@ templates:
     # False means providing a basic template, user needs to add it manually.
     activated: true
     # True means wouldn't show up on the dashboard. Only keeps the definition 
in the storage.
+    disabled: false
+  - name: Spring-Sleuth
+    type: "DASHBOARD"
+    configuration: |-
+      [
+        {
+          "name":"Spring ",

Review comment:
       ```suggestion
             "name":"Spring Sleuth",
   ```
   
   This seems much easier than `meter-receive-config/spring.yaml` provided, 
could you share why? I expect they are matched and used by the end-user 
directly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to