hanahmily opened a new pull request #5174:
URL: https://github.com/apache/skywalking/pull/5174


   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   ___
   ### New feature or improvement
   The labelFilter supports regular expression to filter labels. This feature 
provides a more flexible path for users to extract and aggregate metrics.
   
   For instance,  `http_request_count` metric has a `status` label to indicate 
the status code. If users want to sum all of 4xx(400, 404 and etc) request, 
they can configure `4\d{2}` to match them.
   
   I don't intend to pre-compile the regular expression to improve the 
performance due to the low frequency of the Prometheus fetcher/receiver 
interval. Before some performance concerns are raised, I prefer to use cleaner 
and simpler implement.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to