dagmom commented on pull request #5156: URL: https://github.com/apache/skywalking/pull/5156#issuecomment-664084235
> For finishing this PR, you at least need to query-protocol PR merged and implement here. > Also, considering you have enough time, please add an e2e check for the alarm case. You could take a reference from the e2e TTL, which is using the mesh telemetry to mock data, you could use the same way to mock the data which could trigger the alarm. Then you have everything you need to check. Related to #4530 ok ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
