wu-sheng commented on a change in pull request #5209:
URL: https://github.com/apache/skywalking/pull/5209#discussion_r463643573
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -135,7 +135,12 @@ property key | Description | Default |
`correlation.element_max_number`|Max element count of the correlation
context.|`3`|
`correlation.value_max_length`|Max value length of correlation context
element.|`128`|
`plugin.kafka.bootstrap_servers`| A list of host/port pairs to use for
establishing the initial connection to the Kafka cluster. | `localhost:9092`
-`plugin.kafka.consumer_config`| Kafka producer configuration. |
+`plugin.kafka.consumer_config`| Kafka producer configuration. ||
+`plugin.dubbo.collect_consumer_arguments`| Apache Dubbo consumer collect
`arguments` in RPC call. |`false`|
+`plugin.dubbo.consumer_arguments_length_threshold`| When
`plugin.dubbo.collect_consumer_arguments` is `true`, Arguments of length from
the front will to the OAP backend |`256`|
+`plugin.dubbo.collect_provider_address`| Apache Dubbo provider collect
`remote_address` and `local_address` in RPC call. |`false`|
Review comment:
Notice, the provider side is EntrySpan, which has `#setPeer` too. Please
recheck.
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -135,7 +135,12 @@ property key | Description | Default |
`correlation.element_max_number`|Max element count of the correlation
context.|`3`|
`correlation.value_max_length`|Max value length of correlation context
element.|`128`|
`plugin.kafka.bootstrap_servers`| A list of host/port pairs to use for
establishing the initial connection to the Kafka cluster. | `localhost:9092`
-`plugin.kafka.consumer_config`| Kafka producer configuration. |
+`plugin.kafka.consumer_config`| Kafka producer configuration. ||
Review comment:
```suggestion
`plugin.kafka. producer_config`| Kafka producer configuration. ||
```
@dmsolr Is this a typo in the previous doc? And I think you miss the other
configurations of topic names in here and backend documentations.
Also, backend documents have some typo issues too.
##########
File path: test/plugin/scenarios/dubbo-2.7.x-scenario/bin/startup.sh
##########
@@ -18,4 +18,5 @@
home="$(cd "$(dirname $0)"; pwd)"
-java -jar ${agent_opts} ${home}/../libs/dubbo-2.7.x-scenario.jar &
\ No newline at end of file
+java -Dskywalking.plugin.dubbo.collect_consumer_address=true
-Dskywalking.plugin.dubbo.collect_consumer_arguments=true \
Review comment:
Do you forget to remove this?
`skywalking.plugin.dubbo.collect_consumer_address=true`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
