alonelaval commented on a change in pull request #55:
URL: https://github.com/apache/skywalking-python/pull/55#discussion_r463919800
##########
File path: skywalking/trace/span/__init__.py
##########
@@ -225,5 +226,10 @@ class NoopSpan(Span):
def __init__(self, context: 'SpanContext' = None, kind: 'Kind' = None):
Span.__init__(self, context=context, kind=kind)
+ def extract(self, carrier: 'Carrier') -> 'Span':
+ if carrier is not None:
+ self.context._correlation = carrier.correlation_carrier.correlation
+
def inject(self, carrier: 'Carrier') -> 'Span':
+ carrier.correlation_carrier.correlation = self.context._correlation
Review comment:
I want to protect context._correlation and let the user get or set
values that need to be passed through through put and get
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
