wu-sheng commented on a change in pull request #5209:
URL: https://github.com/apache/skywalking/pull/5209#discussion_r464842293
##########
File path:
apm-sniffer/apm-sdk-plugin/dubbo-2.7.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo/DubboInterceptor.java
##########
@@ -83,16 +94,22 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
}
span =
ContextManager.createEntrySpan(generateOperationName(requestURL, invocation),
contextCarrier);
+ if
(DubboPluginConfig.Plugin.Dubbo.COLLECT_PROVIDER_REMOTE_ADDRESS) {
Review comment:
I prefer you to add this directly, rather than config. This is a light
op, should not affect the performance like the arguments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
