wu-sheng commented on a change in pull request #5235:
URL: https://github.com/apache/skywalking/pull/5235#discussion_r465492039
##########
File path:
apm-sniffer/apm-sdk-plugin/feign-default-http-9.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/feign/http/v9/DefaultHttpClientInterceptor.java
##########
@@ -81,6 +82,16 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
Tags.HTTP.METHOD.set(span, request.method());
Tags.URL.set(span, request.url());
SpanLayer.asHttp(span);
+ if (FeignPluginConfig.Plugin.Feign.TRACE_PARAMS) {
+ if (request.charset() != null && request.body() != null) {
+ String tagValue = new String(request.body(),
request.charset());
Review comment:
This is not just tracking the HTTP parameter, this is tracking the whole
request BODY. The config name and document should be adjusted.
Also, you should do this based on HTTP request type, an HTTP request could
include binary(such as a file), please use the format in the headers to filter
the requests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
