wu-sheng commented on a change in pull request #5235:
URL: https://github.com/apache/skywalking/pull/5235#discussion_r466082720
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -131,6 +131,9 @@ property key | Description | Default |
`plugin.tomcat.collect_http_params`| This config item controls that whether
the Tomcat plugin should collect the parameters of the request. Also, activate
implicitly in the profiled trace. | `false` |
`plugin.springmvc.collect_http_params`| This config item controls that whether
the SpringMVC plugin should collect the parameters of the request, when your
Spring application is based on Tomcat, consider only setting either
`plugin.tomcat.collect_http_params` or `plugin.springmvc.collect_http_params`.
Also, activate implicitly in the profiled trace. | `false` |
`plugin.http.http_params_length_threshold`| When `COLLECT_HTTP_PARAMS` is
enabled, how many characters to keep and send to the OAP backend, use negative
values to keep and send the complete parameters, NB. this config item is added
for the sake of performance. | `1024` |
+`plugin.feign.collect_request_body`| This config item controls that whether
the Feign plugin should collect the http body of the request. | `false` |
+`plugin.feign.filter_length_limit`| When `COLLECT_REQUEST_BODY` is enabled,
how many characters to keep and send to the OAP backend, use negative values to
keep and send the complete body. | `1024` |
+`plugin.feign.supported_content_types_prefix`| When `COLLECT_REQUEST_BODY` is
enabled and content-type start with SUPPORTED_CONTENT_TYPES_PREFIX, collect the
body of the request , multiple paths should be separated by `,` | `1024` |
Review comment:
The default value is incorrect. Is Json the only default option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
