hanahmily commented on a change in pull request #5202:
URL: https://github.com/apache/skywalking/pull/5202#discussion_r466481051
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/MetricsQueryEsDAO.java
##########
@@ -138,42 +139,12 @@ public MetricsValues readMetricsValues(final
MetricsCondition condition,
});
SearchResponse response = getClient().ids(condition.getName(),
ids.toArray(new String[0]));
- Map<String, Map<String, Object>> idMap = toMap(response);
-
- Map<String, MetricsValues> labeledValues = new
HashMap<>(labels.size());
- labels.forEach(label -> {
- MetricsValues labelValue = new MetricsValues();
- labelValue.setLabel(label);
-
- labeledValues.put(label, labelValue);
- });
-
- final int defaultValue =
ValueColumnMetadata.INSTANCE.getDefaultValue(condition.getName());
- for (String id : ids) {
- if (idMap.containsKey(id)) {
- Map<String, Object> source = idMap.get(id);
- DataTable multipleValues = new DataTable((String)
source.getOrDefault(valueColumnName, ""));
-
- labels.forEach(label -> {
- final IntValues values =
labeledValues.get(label).getValues();
- Long data = multipleValues.get(label);
- if (data == null) {
- data = (long) defaultValue;
- }
- KVInt kv = new KVInt();
- kv.setId(id);
- kv.setValue(data);
- values.addKVInt(kv);
- });
- }
-
+ Map<String, DataTable> idMap = new LinkedHashMap<>();
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
