dio commented on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-671006141
It doesn't block technically, but if someone finds out, for example, we don't have package name defined in each of our *.proto. Probably they will raise their eyebrows. The package declaration in the .proto file is the namespace used by the protobuf language. The recommended name pattern will be something like `package company_name.project_name`. As an example, the well-known types are defined in the `google.protobuf` namespace. The lack of a package declaration means that all declarations in your *.proto file are in the top-level global namespace, which seems very highly prone to namespace conflicts. The "new set of APIs" plan above eases the pain if we want to make the linter happy, while we still have the "current" version generates compatible code. However, in the end, It's up to you for sure, whether we want to follow a certain style-guide "approved" by the industry or not. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
