qxo commented on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-671060331
> > With reflection we support oracle/sun and ibm jvm and maybe other jvm > > This is the thing which should be enhanced. You never need a config to activate this accessor. You could use the reflection too. If the target class(es)/method(s) found, then this could be activated. > The current accessor should be the default. > > You should not use SPI(this word), there is no SPI. SPI is the JVM level mechanism. 只所以让实现类可配置是为了其可扩展性：有切入点可以不用直接核实代码而在官方不支持情况提供适配置或兼容处理。 SPI只是技术术语，并不仅限于JVM吧， 而应是反过来的： JVM提供了其SPI方式的扩展机制。我们也可以有其它方式的SPI。 SPI means Service Provider Infrastructure。目的是为了让服务或实现可替换。 If it's not satisfied for you , you may change the code :) 我提交PR目的是为了回馈开源社区， 但没空细究于此了： 按你们喜欢的方式改吧。怎么同时兼容oralce/sun和ibm jvm我已经提供样例，具体如何修改只是技术实现细节问题。 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
