wu-sheng commented on a change in pull request #5304:
URL: https://github.com/apache/skywalking/pull/5304#discussion_r469191164
##########
File path:
apm-sniffer/apm-sdk-plugin/kafka-commons/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/KafkaContext.java
##########
@@ -19,19 +19,30 @@
package org.apache.skywalking.apm.plugin.kafka.define;
-public class SpringKafkaContext {
+public class KafkaContext {
- public SpringKafkaContext() {
+ public KafkaContext(String operationName) {
needStop = false;
+ this.operationName = operationName;
}
private boolean needStop;
Review comment:
I rechecked the codes, this seems not necessary. You always
`needStop=false`. Could we consider to remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
