kezhenxu94 commented on a change in pull request #5293:
URL: https://github.com/apache/skywalking/pull/5293#discussion_r470005086
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -45,6 +45,8 @@ jobs:
bash <(curl -s https://codecov.io/bash)
- name: 'Check Dependencies Licenses'
run: tools/dependencies/check-LICENSE.sh
+ - name: 'Check Javaagent Plugin List'
+ run: tools/plugin/check-javaagent-plugin-list.sh
Review comment:
I suggest to move this to the beginning of the the steps (line 42)
because this script is more lightweight that can fail quickly, and thus
prevents unnecessary `Install & Test`, `Install & Test` is much more expensive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
