wu-sheng commented on a change in pull request #5293:
URL: https://github.com/apache/skywalking/pull/5293#discussion_r470440124
##########
File path: tools/plugin/check-javaagent-plugin-list.sh
##########
@@ -41,10 +41,5 @@ function getMdJavaagentPluginList() {
genernateJavaagentPluginList
getMdJavaagentPluginList
diff -w -bB -U0 ${MD_PLUGINS_LIST} ${GENERNATE_PLUGINS_LIST}
-status=$?
-echo ${status}
-rm -rf ${MD_PLUGINS_LIST}
-rm -rf ${GENERNATE_PLUGINS_LIST}
-[[ ${status} -ne 0 ]] && exit ${status}
Review comment:
What are you testing? I think we need the `exit code` to fail the CI
process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
