wu-sheng commented on a change in pull request #5132:
URL: https://github.com/apache/skywalking/pull/5132#discussion_r470602611
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch7-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch7/query/TraceQueryEs7DAO.java
##########
@@ -124,8 +125,7 @@ public TraceBrief queryBasicTraces(long startSecondTB,
}
sourceBuilder.size(limit);
sourceBuilder.from(from);
-
- SearchResponse response = getClient().search(SegmentRecord.INDEX_NAME,
sourceBuilder);
+ SearchResponse response = getClient().search(new
TimeRangeIndexNameMaker(SegmentRecord.INDEX_NAME, startSecondTB, endSecondTB),
sourceBuilder);
Review comment:
Notice in the current codes, `ElasticSearch7Client` and
`ElasticSearchClient` have their own `#search` methods, your new `#doSearch`
method has not been included in the ES 7 client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
