wu-sheng commented on a change in pull request #42:
URL:
https://github.com/apache/skywalking-query-protocol/pull/42#discussion_r470945748
##########
File path: browser-log.graphqls
##########
@@ -14,22 +14,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# The list of browser error log
-type BrowserErrorLogBrief {
- errorLogs: [BasicBrowserErrorLog!]!
- total: Int!
-}
-
-# Browser error log basic info
-type BasicBrowserErrorLog {
- uniqueId: String!
- pagePath: String!
- time: Long!
- category: ErrorCategory!
-}
-
# Represent the conditions used for query BrowserErrorLogBrief
input BrowserErrorLogQueryCondition {
+ uniqueId: String
Review comment:
My point is, this is most likely a UUID only. No one is really caring
about it. Also, it could be absent and generated by the OAP automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
