wu-sheng commented on a change in pull request #5348:
URL: https://github.com/apache/skywalking/pull/5348#discussion_r472144023
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -132,6 +132,9 @@ property key | Description | Default |
`plugin.tomcat.collect_http_params`| This config item controls that whether
the Tomcat plugin should collect the parameters of the request. Also, activate
implicitly in the profiled trace. | `false` |
`plugin.springmvc.collect_http_params`| This config item controls that whether
the SpringMVC plugin should collect the parameters of the request, when your
Spring application is based on Tomcat, consider only setting either
`plugin.tomcat.collect_http_params` or `plugin.springmvc.collect_http_params`.
Also, activate implicitly in the profiled trace. | `false` |
`plugin.http.http_params_length_threshold`| When `COLLECT_HTTP_PARAMS` is
enabled, how many characters to keep and send to the OAP backend, use negative
values to keep and send the complete parameters, NB. this config item is added
for the sake of performance. | `1024` |
+`plugin.springmvc.collect_http_headers`| This config item controls that
whether the SpringMVC plugin should collect the headers of the request,
activate implicitly in the profiled trace. | `false` |
+`plugin.http.http_headers_length_threshold`| When `COLLECT_HTTP_PARAMS` is
enabled, how many characters to keep and send to the OAP backend, use negative
values to keep and send the complete headers, NB. this config item is added for
the sake of performance. | `1024` |
Review comment:
`COLLECT_HTTP_PARAMS` <- copy/paste issue.
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -132,6 +132,9 @@ property key | Description | Default |
`plugin.tomcat.collect_http_params`| This config item controls that whether
the Tomcat plugin should collect the parameters of the request. Also, activate
implicitly in the profiled trace. | `false` |
`plugin.springmvc.collect_http_params`| This config item controls that whether
the SpringMVC plugin should collect the parameters of the request, when your
Spring application is based on Tomcat, consider only setting either
`plugin.tomcat.collect_http_params` or `plugin.springmvc.collect_http_params`.
Also, activate implicitly in the profiled trace. | `false` |
`plugin.http.http_params_length_threshold`| When `COLLECT_HTTP_PARAMS` is
enabled, how many characters to keep and send to the OAP backend, use negative
values to keep and send the complete parameters, NB. this config item is added
for the sake of performance. | `1024` |
+`plugin.springmvc.collect_http_headers`| This config item controls that
whether the SpringMVC plugin should collect the headers of the request,
activate implicitly in the profiled trace. | `false` |
+`plugin.http.http_headers_length_threshold`| When `COLLECT_HTTP_PARAMS` is
enabled, how many characters to keep and send to the OAP backend, use negative
values to keep and send the complete headers, NB. this config item is added for
the sake of performance. | `1024` |
+`plugin.http.include_http_headers`| When `COLLECT_HTTP_PARAMS` is enabled,
control what header data should collect, this is for security purpose, values
must be lowed case,multi values split by , | `` |
Review comment:
```suggestion
`plugin.http.include_http_headers`| Set the header names, which should be
collected by the plugin. Header name must follow `javax.servlet.http`
definition. Multiple names should be split by comma. | ``(No header would be
collected) |
```
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -132,6 +132,9 @@ property key | Description | Default |
`plugin.tomcat.collect_http_params`| This config item controls that whether
the Tomcat plugin should collect the parameters of the request. Also, activate
implicitly in the profiled trace. | `false` |
`plugin.springmvc.collect_http_params`| This config item controls that whether
the SpringMVC plugin should collect the parameters of the request, when your
Spring application is based on Tomcat, consider only setting either
`plugin.tomcat.collect_http_params` or `plugin.springmvc.collect_http_params`.
Also, activate implicitly in the profiled trace. | `false` |
`plugin.http.http_params_length_threshold`| When `COLLECT_HTTP_PARAMS` is
enabled, how many characters to keep and send to the OAP backend, use negative
values to keep and send the complete parameters, NB. this config item is added
for the sake of performance. | `1024` |
+`plugin.springmvc.collect_http_headers`| This config item controls that
whether the SpringMVC plugin should collect the headers of the request,
activate implicitly in the profiled trace. | `false` |
+`plugin.http.http_headers_length_threshold`| When `COLLECT_HTTP_PARAMS` is
enabled, how many characters to keep and send to the OAP backend, use negative
values to keep and send the complete headers, NB. this config item is added for
the sake of performance. | `1024` |
Review comment:
```suggestion
`plugin.http.http_headers_length_threshold`| When `include_http_headers`
declares header names, this threshold controls the length limitation of all
header values. Note. this config item is added for the sake of performance. |
`1024` |
```
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -132,6 +132,9 @@ property key | Description | Default |
`plugin.tomcat.collect_http_params`| This config item controls that whether
the Tomcat plugin should collect the parameters of the request. Also, activate
implicitly in the profiled trace. | `false` |
`plugin.springmvc.collect_http_params`| This config item controls that whether
the SpringMVC plugin should collect the parameters of the request, when your
Spring application is based on Tomcat, consider only setting either
`plugin.tomcat.collect_http_params` or `plugin.springmvc.collect_http_params`.
Also, activate implicitly in the profiled trace. | `false` |
`plugin.http.http_params_length_threshold`| When `COLLECT_HTTP_PARAMS` is
enabled, how many characters to keep and send to the OAP backend, use negative
values to keep and send the complete parameters, NB. this config item is added
for the sake of performance. | `1024` |
+`plugin.springmvc.collect_http_headers`| This config item controls that
whether the SpringMVC plugin should collect the headers of the request,
activate implicitly in the profiled trace. | `false` |
Review comment:
This is not necessary. header collecting should work once the
`include_http_headers` not empty.
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -132,6 +132,9 @@ property key | Description | Default |
`plugin.tomcat.collect_http_params`| This config item controls that whether
the Tomcat plugin should collect the parameters of the request. Also, activate
implicitly in the profiled trace. | `false` |
`plugin.springmvc.collect_http_params`| This config item controls that whether
the SpringMVC plugin should collect the parameters of the request, when your
Spring application is based on Tomcat, consider only setting either
`plugin.tomcat.collect_http_params` or `plugin.springmvc.collect_http_params`.
Also, activate implicitly in the profiled trace. | `false` |
`plugin.http.http_params_length_threshold`| When `COLLECT_HTTP_PARAMS` is
enabled, how many characters to keep and send to the OAP backend, use negative
values to keep and send the complete parameters, NB. this config item is added
for the sake of performance. | `1024` |
+`plugin.springmvc.collect_http_headers`| This config item controls that
whether the SpringMVC plugin should collect the headers of the request,
activate implicitly in the profiled trace. | `false` |
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
