wu-sheng commented on a change in pull request #5347:
URL: https://github.com/apache/skywalking/pull/5347#discussion_r472246233
##########
File path:
apm-sniffer/apm-sdk-plugin/elastic-job-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/elasticjob/ElasticJobExecutorInterceptor.java
##########
@@ -36,7 +35,7 @@ public void beforeMethod(EnhancedInstance objInst, Method
method, Object[] allAr
ShardingContexts shardingContexts = (ShardingContexts) allArguments[0];
Integer item = (Integer) allArguments[1];
String operateName = ComponentsDefine.ELASTIC_JOB.getName() + "/" +
shardingContexts.getJobName();
- AbstractSpan span = ContextManager.createEntrySpan(operateName, new
ContextCarrier());
+ AbstractSpan span = ContextManager.createLocalSpan(operateName);
Review comment:
@tristaZero @terrymanu After this is added, on the SkyWalking UI, you
will have the job metrics, besides the traces, including
1. Execution time, including avg, percentile
1. Successful rate, determined through whether the main entrance has an
exception
1. What other endpoints(HTTP/gRPC) this task depends on.
This is a thing we called the logic endpoint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
