lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473561669



##########
File path: 
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
##########
@@ -203,4 +213,25 @@ public void onError(final String typeName,
         public void onComplete(String typeName, ClassLoader classLoader, 
JavaModule module, boolean loaded) {
         }
     }
+
+    static void configureLogger() {

Review comment:
       The problem here is now the resolver is set to `PatternResolver` by 
default.
   
   We have to setup the resolver before any `LogManager.getLogger(...)` is 
called. So this method is supposed to used in the static block of 
`SkywalkingAgent`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to