lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473571907
##########
File path:
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
##########
@@ -203,4 +213,25 @@ public void onError(final String typeName,
public void onComplete(String typeName, ClassLoader classLoader,
JavaModule module, boolean loaded) {
}
}
+
+ static void configureLogger() {
Review comment:
> I am not saying this, take a closer look about how we initialize the
Config's fields.
Yes. I understand the dynamic injection is implemented in
`SnifferConfigInitializer` with the help of `ConfigInitializer`.
Now I take advantage of `ConfigInitializer`, in which the `logger` is
declared but actually not used, to inject the system properties, though
limitation is still there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
