wu-sheng commented on a change in pull request #5352:
URL: https://github.com/apache/skywalking/pull/5352#discussion_r473667230



##########
File path: test/plugin/containers/jvm-container/pom.xml
##########
@@ -32,8 +32,63 @@
     <artifactId>jvm-container</artifactId>
     <name>SkyWalking JVM Runner Image</name>
 
-    <properties>
-        <skip.docker>false</skip.docker>
-        <docker.image.name>skywalking/agent-test-jvm</docker.image.name>
-    </properties>
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>io.fabric8</groupId>
+                <artifactId>docker-maven-plugin</artifactId>
+                <version>0.33.0</version>
+                <configuration>
+                    <images>
+                        <image>
+                            <name>skywalking/agent-test-jvm:${BUILD_NO}</name>
+                            <build>
+                                <from>openjdk:8</from>
+                                <workdir>/usr/local/skywalking/tools</workdir>
+                                <assembly>
+                                    <mode>dir</mode>
+                                    
<targetDir>/usr/local/skywalking</targetDir>
+                                    <descriptor>assembly.xml</descriptor>
+                                </assembly>
+                                <runCmds>
+                                    <run>chmod +x 
/usr/local/skywalking/run.sh</run>
+                                    <run>tar -xvf 
../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
+                                </runCmds>
+                                
<workdir>/usr/local/skywalking/scenario</workdir>
+                                <cmd>/usr/local/skywalking/run.sh</cmd>
+                            </build>
+                        </image>
+                        <image>
+                            
<name>skywalking/agent-test-jvm:jdk14-${BUILD_NO}</name>

Review comment:
       Why I can't find the place to declare using this image? Could you point 
out?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to