lujiajing1126 opened a new issue #5362:
URL: https://github.com/apache/skywalking/issues/5362


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [x] Feature or performance improvement
   
   ___
   ### Requirement or improvement
   
   As discussed in PR #5357 , any constant class members MUST only contain 
capital characters, numbers and `_`, except that it can be named as `logger`.
   
   The related code is listed below,
   
   
https://github.com/apache/skywalking/blob/bcc27eb6cf9e9a5b01fbbd0a9899692185d3053d/apm-checkstyle/checkStyle.xml#L82
   
   We reach an agreement that this additional rule should be removed and the 
code should be adapted to the new style. 
   
   A new PR has to be created to focus on this issue. Also, this new PR should 
be merged before #5357 .
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to