wu-sheng opened a new pull request #5408:
URL: https://github.com/apache/skywalking/pull/5408


   @peng-yongsheng reported this conflict. As they used to extend the same core 
service, when both of them are active, which could happen, they can't work 
together.
   
   But, from the design perspective, I notice, ignore plugin actually is just a 
sampling service. It used `ContextManagerExtendService` extension, just because 
only sampling service API doesn't provide the operation name.
   
   In this PR, I changed the sampling service API, and move 
`TraceIgnoreExtendService` to extend it. So conflict goes away.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to