wu-sheng commented on a change in pull request #5413:
URL: https://github.com/apache/skywalking/pull/5413#discussion_r479779929



##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -170,6 +170,7 @@ Now, we have the following known optional plugins.
 * Plugin of Spring Cloud Gateway 2.1.x in optional plugin folder. Please only 
active this plugin when you install agent in Spring Gateway. 
spring-cloud-gateway-2.x-plugin and spring-webflux-5.x-plugin are both required.
 * Plugin of Spring Transaction in optional plugin folder. The reason of being 
optional plugin is, many local span are generated, which also spend more CPU, 
memory and network.
 * [Plugin of Kotlin 
coroutine](agent-optional-plugins/Kotlin-Coroutine-plugin.md) provides the 
tracing across coroutines automatically. As it will add local spans to all 
across routines scenarios, Please assess the performance impact.
+* Plugin of quartz-scheduler-2.x in optional plugin folder. The reason of 
being optional plugin is, many task scheduling system are based on 
quartz-scheduler, this will caused duplicate tracing.

Review comment:
       ```suggestion
   * Plugin of quartz-scheduler-2.x in the optional plugin folder. The reason 
for being an optional plugin is, many task scheduling systems are based on 
quartz-scheduler, this will cause duplicate tracing and link different 
sub-tasks as they share the same quartz level trigger, such as ElasticJob.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to