EvanLjp commented on pull request #5416:
URL: https://github.com/apache/skywalking/pull/5416#issuecomment-686323119


   > A reminder, if you want to be a committer in the future, you need to pay 
more attention to the details, because as a committer, you will have the 
responsibility to review and merge other people's pull requests.
   > 
   > Currently, you are bringing many useful features in the community, but I 
also notice your pull requests usually are requiring many reviews about the 
details, such as English grammar, test cases, comments, naming, local testing. 
I hope you could improve on these too.
   > 
   > Your pull request requires my 2-4 times to do a review, which is a high 
workload for me. Currently, this is not a problem for me, but in one day, when 
you are a committer, even potential PMC, the project code quality will become 
your responsibility.
   
   thx for your notice,would be remember it later.
   i was still to solve the ci process failure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to