wu-sheng commented on a change in pull request #5454:
URL: https://github.com/apache/skywalking/pull/5454#discussion_r484859863



##########
File path: 
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceInstanceRelation.java
##########
@@ -103,6 +103,9 @@ public String getEntityId() {
     @Getter
     @Setter
     private DetectPoint detectPoint;
+    @Getter
+    @Setter
+    private String tlsMode;

Review comment:
       This and service relation source have been changed, 
`scope-definitions.md` doc should be updated. 
   
   > service_relation_mtls_cpm = from(ServiceRelation.*).filter(tlsMode == 
"mTLS").cpm();
   
   This example should belong to the doc I pointed to you.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to