Lumia001 edited a comment on issue #3294:
URL: https://github.com/apache/skywalking/issues/3294#issuecomment-690968815


   It seems to be no.
   And I know, it is neither SW's responsibility nor Dubbo's responsibility, 
just wanna solve it...
   
   Recently, I did upgrade dubbo's version from Dubbox-2.8.4 to  
apache-dubbo-2.7.7. Both of them have the same limit.
   
   Here is Apache Dubbo-2.7.7's source.
   ------------------------------------------------------------
   ```
   @Override
       public void filter(ClientRequestContext requestContext) throws 
IOException {
           int size = 0;
           for (Map.Entry<String, Object> entry : 
RpcContext.getContext().getObjectAttachments().entrySet()) {
               String key = entry.getKey();
               String value = (String) entry.getValue();
               if (illegalHttpHeaderKey(key) || illegalHttpHeaderValue(value)) {
                   throw new IllegalArgumentException("The attachments of " + 
RpcContext.class.getSimpleName() + " must not contain ',' or '=' when using 
rest protocol");
               }
   
               // TODO for now we don't consider the differences of encoding 
and server limit
               if (value != null) {
                   size += value.getBytes(StandardCharsets.UTF_8).length;
               }
               if (size > MAX_HEADER_SIZE) {
                   throw new IllegalArgumentException("The attachments of " + 
RpcContext.class.getSimpleName() + " is too big");
               }
   
               String attachments = key + "=" + value;
               requestContext.getHeaders().add(DUBBO_ATTACHMENT_HEADER, 
attachments);
           }
       }
   
   
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to