wu-sheng commented on pull request #5474: URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691398937
@kezhenxu94 We had a discussion here, https://github.com/apache/skywalking/issues/5460. Please take a look. From my personal preference, I don't like the integration API in the same method. Because they belong to different enterprises. They definitely will not consider others' API, if they are going to upgrade one day. Such as, they could request a header or different authentication way. If one day, something is not incompatible, we have to add strange `if/else`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
