wu-sheng commented on a change in pull request #5509:
URL: https://github.com/apache/skywalking/pull/5509#discussion_r490083278
##########
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/slack/SlackhookCallback.java
##########
@@ -77,31 +77,26 @@ public void doAlarm(List<AlarmMessage> alarmMessages) {
StringEntity entity;
try {
-
JsonObject jsonObject = new JsonObject();
JsonArray jsonElements = new JsonArray();
-
alarmMessages.forEach(item -> {
jsonElements.add(GSON.fromJson(
String.format(
this.alarmRulesWatcher.getSlackSettings().getTextTemplate(),
item.getAlarmMessage()
), JsonObject.class));
});
-
jsonObject.add("blocks", jsonElements);
-
entity = new StringEntity(GSON.toJson(jsonObject),
ContentType.APPLICATION_JSON);
-
post.setEntity(entity);
CloseableHttpResponse httpResponse =
httpClient.execute(post);
StatusLine statusLine = httpResponse.getStatusLine();
if (statusLine != null && statusLine.getStatusCode() !=
HttpStatus.SC_OK) {
- log.error("send alarm to " + url + " failure. Response
code: " + statusLine.getStatusCode());
+ log.error("Send slack alarm to {} failure. Response
code: {}", url , statusLine.getStatusCode());
}
} catch (UnsupportedEncodingException e) {
- log.error("Alarm to JSON error, " + e.getMessage(), e);
+ log.error("Alarm to JSON error, {} ", e.getMessage(), e);
} catch (IOException e) {
- log.error("send alarm to " + url + " failure.", e);
+ log.error("Send slack alarm to {} failure.", url , e);
Review comment:
Thanks for the demo codes. Interesting, the comments of methods are not
consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
