lujiajing1126 commented on a change in pull request #5510:
URL: https://github.com/apache/skywalking/pull/5510#discussion_r490691185
##########
File path:
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/ProducerConstructorMapInterceptor.java
##########
@@ -22,16 +22,27 @@
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
import org.apache.skywalking.apm.util.StringUtil;
+import java.util.List;
import java.util.Map;
+import java.util.regex.Pattern;
+/**
+ * Target at kafka-clients >=2.1.0
Review comment:
> Still confused what your new comments. Isn't 2.0 even 1.x client
libraries using this interceptor?
I see. You are right. It can be used even below 2.0, if users intend to use
Map type constructors.
I have removed this comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
