wu-sheng commented on a change in pull request #5524:
URL: https://github.com/apache/skywalking/pull/5524#discussion_r491704015
##########
File path: test/plugin/scenarios/mongodb-3.x-scenario/bin/startup.sh
##########
@@ -18,4 +18,4 @@
home="$(cd "$(dirname $0)"; pwd)"
-java -jar ${agent_opts} ${home}/../libs/mongodb-3.x-scenario.jar &
\ No newline at end of file
+java -jar -Dskywalking.plugin.mongodb.trace_param=true ${agent_opts}
${home}/../libs/mongodb-3.x-scenario.jar &
Review comment:
You activated this, but can't see the param in the tags.
##########
File path: test/plugin/scenarios/mongodb-3.x-scenario/bin/startup.sh
##########
@@ -18,4 +18,4 @@
home="$(cd "$(dirname $0)"; pwd)"
-java -jar ${agent_opts} ${home}/../libs/mongodb-3.x-scenario.jar &
\ No newline at end of file
+java -jar -Dskywalking.plugin.mongodb.trace_param=true ${agent_opts}
${home}/../libs/mongodb-3.x-scenario.jar &
Review comment:
What do you mean `error`? Why CI reports success?
##########
File path: test/plugin/scenarios/mongodb-3.x-scenario/bin/startup.sh
##########
@@ -18,4 +18,4 @@
home="$(cd "$(dirname $0)"; pwd)"
-java -jar ${agent_opts} ${home}/../libs/mongodb-3.x-scenario.jar &
\ No newline at end of file
+java -jar -Dskywalking.plugin.mongodb.trace_param=true ${agent_opts}
${home}/../libs/mongodb-3.x-scenario.jar &
Review comment:
> param is db.statement,In terms of content judgment
Also, this place seems like a bug. The parameter should be another tag, like
other plugins. Could you fix them too? And if no parameter exists, the tag
should not be there too.
##########
File path: test/plugin/scenarios/mongodb-3.x-scenario/bin/startup.sh
##########
@@ -18,4 +18,4 @@
home="$(cd "$(dirname $0)"; pwd)"
-java -jar ${agent_opts} ${home}/../libs/mongodb-3.x-scenario.jar &
\ No newline at end of file
+java -jar -Dskywalking.plugin.mongodb.trace_param=true ${agent_opts}
${home}/../libs/mongodb-3.x-scenario.jar &
Review comment:
Let's adjust the tag and don't worry about this check for now, OK?
##########
File path: test/plugin/scenarios/mongodb-3.x-scenario/bin/startup.sh
##########
@@ -18,4 +18,4 @@
home="$(cd "$(dirname $0)"; pwd)"
-java -jar ${agent_opts} ${home}/../libs/mongodb-3.x-scenario.jar &
\ No newline at end of file
+java -jar -Dskywalking.plugin.mongodb.trace_param=true ${agent_opts}
${home}/../libs/mongodb-3.x-scenario.jar &
Review comment:
Wait, is the statement including the entity name of the operation or not?
##########
File path: test/plugin/scenarios/mongodb-3.x-scenario/bin/startup.sh
##########
@@ -18,4 +18,4 @@
home="$(cd "$(dirname $0)"; pwd)"
-java -jar ${agent_opts} ${home}/../libs/mongodb-3.x-scenario.jar &
\ No newline at end of file
+java -jar -Dskywalking.plugin.mongodb.trace_param=true ${agent_opts}
${home}/../libs/mongodb-3.x-scenario.jar &
Review comment:
From my reading from your screenshot, only operation is a part of the
statement, I think the plugin code has some issue about assembling the
statement and parameter. Statement should be an expression and parameters are
variable. I am not sure whether mongodb is friendly to this?
##########
File path: test/plugin/scenarios/mongodb-3.x-scenario/bin/startup.sh
##########
@@ -18,4 +18,4 @@
home="$(cd "$(dirname $0)"; pwd)"
-java -jar ${agent_opts} ${home}/../libs/mongodb-3.x-scenario.jar &
\ No newline at end of file
+java -jar -Dskywalking.plugin.mongodb.trace_param=true ${agent_opts}
${home}/../libs/mongodb-3.x-scenario.jar &
Review comment:
I just read the codes again, the statement tag should be removed, as
this actually isn't a statement anymore. We should use `DB_BIND_VARIABLES` tag
to replace `DB_STATEMENT`, because the statement is being used to check slow
SQL. Also, please help to remove the `executeMethod` as the prefix, it has been
the operation name of the span.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
