wu-sheng commented on pull request #5523:
URL: https://github.com/apache/skywalking/pull/5523#issuecomment-697081340


   @yu199195 This PR is not ready to be merged, there are 2 things left
   1. The implementations of meter core are duplicated in the toolkit and agent 
core both. I have informed @mrproliu, he need to merge them and re-implement by 
referring the OpenTracing toolkit way. Toolkit lib should include a shell only.
   1. After (1), we need to deploy the snapshot version for the API toolkit on 
the Apache snapshot repo, then the tests could pass, and you could use that 
toolkit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to