wu-sheng commented on a change in pull request #5493:
URL: https://github.com/apache/skywalking/pull/5493#discussion_r492610311
##########
File path:
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
##########
@@ -178,4 +178,6 @@
public static final OfficialComponent QUARTZ_SCHEDULER = new
OfficialComponent(97, "quartz-scheduler");
public static final OfficialComponent XXL_JOB = new OfficialComponent(98,
"xxl-job");
-}
+
+ public static final OfficialComponent SPRING_WEBCLIENT = new
OfficialComponent(99, "spring-webflux-5.x-webclient");
Review comment:
A component should not include the version.
##########
File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml
##########
@@ -321,6 +321,22 @@ segmentItems:
- {key: url, value: not null}
- {key: http.method, value: GET}
skipAnalysis: 'false'
+ - operationName: /testcase/webclient/server
Review comment:
Where is the server-side segment with ref to match this?
##########
File path:
test/plugin/scenarios/webflux-scenario/webflux-projectB-scenario/src/main/java/test/apache/skywalking/apm/testcase/sc/webflux/projectB/controller/TestAnnotationController.java
##########
@@ -44,6 +44,11 @@ public String error() {
}
return "1";
}
+
+ @RequestMapping("/testcase/webclient/server")
Review comment:
This should be traced in the expected data. Please recheck.
##########
File path:
test/plugin/scenarios/webflux-scenario/webflux-projectB-scenario/src/main/java/test/apache/skywalking/apm/testcase/sc/webflux/projectB/controller/TestAnnotationController.java
##########
@@ -44,6 +44,11 @@ public String error() {
}
return "1";
}
+
+ @RequestMapping("/testcase/webclient/server")
Review comment:
What do you mean `finish too fast`? I can't find the `entry span` and
`segment` in your expected data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
