vcjmhg commented on a change in pull request #5493:
URL: https://github.com/apache/skywalking/pull/5493#discussion_r492612463



##########
File path: 
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
##########
@@ -178,4 +178,6 @@
     public static final OfficialComponent QUARTZ_SCHEDULER = new 
OfficialComponent(97, "quartz-scheduler");
 
     public static final OfficialComponent XXL_JOB = new OfficialComponent(98, 
"xxl-job");
-}
+
+    public static final OfficialComponent SPRING_WEBCLIENT = new 
OfficialComponent(99, "spring-webflux-5.x-webclient");

Review comment:
       ok,I wiil modefy it after this CI finished.

##########
File path: 
test/plugin/scenarios/webflux-scenario/webflux-projectB-scenario/src/main/java/test/apache/skywalking/apm/testcase/sc/webflux/projectB/controller/TestAnnotationController.java
##########
@@ -44,6 +44,11 @@ public String error() {
         }
         return "1";
     }
+    
+    @RequestMapping("/testcase/webclient/server")

Review comment:
       ok,It seems `/testcase/webclient/sercer` finished too fast,I will 
recheck it.

##########
File path: 
test/plugin/scenarios/webflux-scenario/webflux-projectB-scenario/src/main/java/test/apache/skywalking/apm/testcase/sc/webflux/projectB/controller/TestAnnotationController.java
##########
@@ -44,6 +44,11 @@ public String error() {
         }
         return "1";
     }
+    
+    @RequestMapping("/testcase/webclient/server")

Review comment:
       ok,It seems `/testcase/webclient/server` finished too fast,I will 
recheck it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to