kezhenxu94 commented on issue #5556:
URL: https://github.com/apache/skywalking/issues/5556#issuecomment-698959305
> It will only skip cancelling the first of the runs matching the same
("branch", "repo", "event type"). So I think this is what you expect.
"first of the runs matching..." means the latest run? We expect it to skip
cancelling the most recent run, i.e. only keep the most recent run and cancel
all previous runs, ignoring whether the runs are before/after the current
cancelling run.
> If you add dependency between those batches, they will overall not run as
fast as if you schedule all of them, but at least they will become "snappier"
and easier to cancel by the subsequent commit from the same branch/repo/event
type.
It's right for sure, we've been balancing the batch size and the running
time for so long to reduce the waiting time as much as possible, for
SkyWalking, we have 700 ~ 800+ test cases for every pull request, and now we
batch them into ~100 matrices, which overall takes about 1h and completely run
out of the slots, adding dependency will line up much more longer and take much
more time
> I am also not sure how your workflow looks like, but in our case there are
several preparatory steps before we launch "bigger number of jobs tests". And
they run for long enough time (and free slots) so that when the next commit
from the same branch is pushed, the "old" tests have not started yet and they
are not yet blocking the slots.
We don't actually have such kind of preparatory steps in SkyWalking, the
heavy part is plugin tests and they don't have much preparation work, not to
say running a long time
> I honestly think this scenario when a person pushing the PR will quickly
push a fixup is very, very common and being able to respond to it and cancel
such runs even if you need to do some adaptations and workarounds in your
workflow are worth it :).
I'm totally agree that it's very common, and that's the case in SkyWalking,
we're manually cancelling some old jobs from time to time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
