wu-sheng commented on pull request #42: URL: https://github.com/apache/skywalking-nginx-lua/pull/42#issuecomment-699574888
tag=`status_code` is already available at the core level and other agents. We could add it here. Also, this logic is widely used in the Java agent too, take a look at this, https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-sdk-plugin/httpClient-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpClient/v4/HttpClientExecuteInterceptor.java#L84-L87. You could find many codes like this. They even use `>=400`, rather than `>=500`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
