muse-dev[bot] commented on a change in pull request #5571: URL: https://github.com/apache/skywalking/pull/5571#discussion_r495667530
########## File path: apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/MD5Util.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.util; + +import java.security.MessageDigest; +import java.security.NoSuchAlgorithmException; + +public class MD5Util { + /** + * 16 Bit MD5 RSA + */ + public static String md516BitUpper(String string) { + return md5(string).substring(8, 24).toUpperCase(); + } + + /** + * 32 Bit MD5 RSA + */ + public static String md532BitUpper(String string) { + return md5(string).toUpperCase(); + } + + private static String md5(final String string) { + try { + MessageDigest md = MessageDigest.getInstance("MD5"); Review comment: *BAD_HEXA_CONVERSION:* Leading zeros are omitted in the concatenation increasing collision potential [(details)](https://find-sec-bugs.github.io/bugs.htm#BAD_HEXA_CONVERSION) ########## File path: apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/MD5Util.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.util; + +import java.security.MessageDigest; +import java.security.NoSuchAlgorithmException; + +public class MD5Util { + /** + * 16 Bit MD5 RSA + */ + public static String md516BitUpper(String string) { + return md5(string).substring(8, 24).toUpperCase(); + } + + /** + * 32 Bit MD5 RSA + */ + public static String md532BitUpper(String string) { + return md5(string).toUpperCase(); + } + + private static String md5(final String string) { + try { + MessageDigest md = MessageDigest.getInstance("MD5"); Review comment: *WEAK_MESSAGE_DIGEST_MD5:* This API MD5 (MDX) is not a recommended cryptographic hash function [(details)](https://find-sec-bugs.github.io/bugs.htm#WEAK_MESSAGE_DIGEST_MD5) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
