wu-sheng commented on a change in pull request #5644: URL: https://github.com/apache/skywalking/pull/5644#discussion_r502783228
########## File path: apm-sniffer/apm-sdk-plugin/thrift-plugin/src/main/java/org/apache/skywalking/apm/plugin/thrift/client/TAsyncMethodCallInterceptor.java ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.plugin.thrift.client; + +import java.lang.reflect.Method; +import org.apache.skywalking.apm.agent.core.context.AsyncSpan; +import org.apache.skywalking.apm.agent.core.context.ContextManager; +import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; +import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult; +import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; +import org.apache.skywalking.apm.plugin.thrift.commons.ReflectionUtils; +import org.apache.thrift.async.AsyncMethodCallback; +import org.apache.thrift.async.TAsyncMethodCall; + +/** + * @see TAsyncMethodCall is asynchronized client. + * @see TServiceClientInterceptor to know synchronized client. + */ +public class TAsyncMethodCallInterceptor implements InstanceConstructorInterceptor, InstanceMethodsAroundInterceptor { + private String remotePeer = "UNKNOWN"; + + @Override + public void onConstruct(EnhancedInstance objInst, + Object[] allArguments) throws NoSuchFieldException, IllegalAccessException { + ReflectionUtils.setValue(TAsyncMethodCall.class, objInst, "callback", new AsyncMethodCallback<Object>() { + final AsyncMethodCallback callback = (AsyncMethodCallback) allArguments[3]; + + @Override + public void onComplete(final Object response) { + try { + AsyncSpan span = (AsyncSpan) objInst.getSkyWalkingDynamicField(); + span.asyncFinish(); + } finally { + callback.onComplete(response); + } + } + + @Override + public void onError(final Exception exception) { + try { + AsyncSpan span = (AsyncSpan) objInst.getSkyWalkingDynamicField(); + span.asyncFinish().errorOccurred().log(exception); + } finally { + callback.onError(exception); + } + } + }); + if (allArguments[2] instanceof EnhancedInstance) { + remotePeer = (String) ((EnhancedInstance) allArguments[2]).getSkyWalkingDynamicField(); + } + } + + @Override + public void beforeMethod(EnhancedInstance objInst, + Method method, + Object[] allArguments, + Class<?>[] argumentsTypes, + MethodInterceptResult result) throws Throwable { + // TODO: It is hard to get arguments of method. So, currently, we don't do that. If you have a good idea, please fix it. Review comment: What do you mean TODO? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
