dmsolr commented on a change in pull request #5718:
URL: https://github.com/apache/skywalking/pull/5718#discussion_r511784810
##########
File path:
oap-server/server-fetcher-plugin/kafka-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/analyzer/agent/kafka/KafkaFetcherHandlerRegister.java
##########
@@ -132,16 +157,21 @@ public void start() {
@Override
public void run() {
while (true) {
- ConsumerRecords<String, Bytes> consumerRecords =
consumer.poll(Duration.ofMillis(500L));
- if (!consumerRecords.isEmpty()) {
- Iterator<ConsumerRecord<String, Bytes>> iterator =
consumerRecords.iterator();
- while (iterator.hasNext()) {
- ConsumerRecord<String, Bytes> record = iterator.next();
- handlerMap.get(record.topic()).handle(record);
+ try {
Review comment:
I don't think we still need this single thread pool when we introduce
the thread pool. @zifeihan
Could we use the same one?
https://github.com/apache/skywalking/blob/b79436e798546102781b9e57f1116eb74113a7d8/oap-server/server-fetcher-plugin/kafka-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/analyzer/agent/kafka/KafkaFetcherHandlerRegister.java#L154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
